Add groupId to optional DKIM records in godaddy.com.aab.json#1447
Open
rkorin-godaddy wants to merge 3 commits into
Open
Add groupId to optional DKIM records in godaddy.com.aab.json#1447rkorin-godaddy wants to merge 3 commits into
rkorin-godaddy wants to merge 3 commits into
Conversation
Mark the _acme-challenge CNAME (groupId: ssl) and both _domainkey CNAMEs (groupId: dkim) as optional groups so callers can skip them when dcv or dkimSuffix variables are not available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
|
Version bump needed for the files: |
Linter OK
|
| Level | Code | Note |
|---|---|---|
| info | DCTL1032 | mix of empty and defined record groupId values |
github-actions
Bot
added
PR description incomplete
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
groupId: dkimto the two DKIM CNAME records in the GoDaddy Airo App Builder template so callers can skip them whendkimSuffixis not available:secureserver1._domainkeyCNAME →groupId: dkimsecureserver2._domainkeyCNAME →groupId: dkimAll other records (A, www CNAME,
_acme-challengeCNAME, SPFM, DMARC TXT) remain required.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
syncPubKeyDomainis set — this is mandatorywarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flowSPFMrecord type usedtxtConflictMatchingModeis set on the DMARC TXT recordhostlabelhostfield to create a subdomain%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon the DMARC recordOnline Editor test results
Editor test link(s):